New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample simultaneously #35
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 99.44% 99.89% +0.44%
==========================================
Files 45 53 +8
Lines 2163 2859 +696
==========================================
+ Hits 2151 2856 +705
+ Misses 12 3 -9 ☔ View full report in Codecov by Sentry. |
Merge after #34, contains those commits
This PR adds support for simultaneously sampling from multiple chains at once. This is triggered by having
pars
be a matrix rather than a vector when passed into a sampler/model. Models will need to be able to support this and we don't assume that they do; the propertyallow_multiple_parameters
can be used to signal this.This functionality has two purposes:
There are lots of changes here, but I think it does all need to come though at once or it loses context. Let's chat through the ideas this week.
Things to note:
details
is collected at the end of a run; I've not done this even though it's only a few linesallow_multiple_parameters
as a name, but can't think of a better one