Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JDK17 #660

Merged
merged 4 commits into from Jun 28, 2022
Merged

Support JDK17 #660

merged 4 commits into from Jun 28, 2022

Conversation

xerial
Copy link
Member

@xerial xerial commented Jun 28, 2022

To use JDK17 + DirectByteBuffer, we need to set two JVM options:

--add-opens=java.base/java.nio=ALL-UNNAMED
--add-opens=java.base/sun.nio.ch=ALL-UNNAMED

This PR adds:

  • CI for JDK17
  • Add a workaround even if these JVM options are not set.
  • Add a warning message when DirectByteBuffer is used in JDK17 without setting these JVM options

Related approaches:

Fixes #600

@xerial xerial marked this pull request as ready for review June 28, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working in 17 JDK
1 participant