updates ruby-yajl to 1.2.0 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,13 +3,12 @@ source :rubygems | |||
| gem "faraday", "~> 0.5.7" | |||
|
|
|||
| gem "excon", "~> 0.5.6" | |||
| gem "yajl-ruby", "~> 0.8.1", :require => "yajl" | |||
| gem "yajl-ruby" "1.2.0" | |||
There was a problem hiding this comment.
This will need to get updated in the gemspec as well and you'll probably want to loosen the dependency up a bit. ~> 1.2.0 would be better
There was a problem hiding this comment.
The comma was removed here and needs to be added back.
Also agree that the we want to keep the ~> specification.
|
Thanks for this! Just a few minor fixes and there shouldn't be any problem with moving forward with this. NOTE: I've not tested this change and don't intend to (this project is not actively maintained by me or anyone). I highly recommend you build a prerelease gem from this branch, vendor it in your app, and test it out locally to confirm these changes work as you expect. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.