Fix support for redirected stdin on Windows #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @muesli. I was wondering if I could get approval to run the PR workflows here. I'd love to contribute & help fix this bug. Thank you! |
|
Sorry for the delayed response, but of course I'm happy to approve the CI workflows! |
|
Hello @muesli. It looks like the CI passed - did you have any comments on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7.
I updated the README here, and added a check to
NewReaderto ensure the supplied reader is a console.I also created a unit test that runs
NewReaderin a child process with a redirected stdin. It should work on both unix and Windows platforms. Without this fix, the test will fail on Windows.