Skip to content

Commit

Permalink
Merge pull request #16 from stirante/master
Browse files Browse the repository at this point in the history
Ignore quotes inside comments
  • Loading branch information
muhammadmuzzammil1998 committed Feb 9, 2024
2 parents 2826da8 + 008e358 commit 9d456f0
Show file tree
Hide file tree
Showing 2 changed files with 117 additions and 117 deletions.
2 changes: 1 addition & 1 deletion jsonc_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func init() {
jsoncTest = testsStruct{
validBlock: b(`{"foo": /** this is a bloc/k comm\"ent */ "bar foo", "true": /* true */ false, "number": 42, "object": { "test": "done" }, "array" : [1, 2, 3], "url" : "https://github.com", "escape":"\"wo//rking" }`),
invalidBlock: b(`{"foo": /* this is a block comment "bar foo", "true": false, "number": 42, "object": { "test": "done" }, "array" : [1, 2, 3], "url" : "https://github.com", "escape":"\"wo//rking }`),
validSingle: b("{\"foo\": // this is a single line comm\\\"ent\n\"bar foo\", \"true\": false, \"number\": 42, \"object\": { \"test\": \"done\" }, \"array\" : [1, 2, 3], \"url\" : \"https://github.com\", \"escape\":\"\\\"wo//rking\" }"),
validSingle: b("{\"foo\": // this is a \"single **/line comm\\\"ent\n\"bar foo\", \"true\": false, \"number\": 42, \"object\": { \"test\": \"done\" }, \"array\" : [1, 2, 3], \"url\" : \"https://github.com\", \"escape\":\"\\\"wo//rking\" }"),
invalidSingle: b(`{"foo": // this is a single line comment "bar foo", "true": false, "number": 42, "object": { "test": "done" }, "array" : [1, 2, 3], "url" : "https://github.com", "escape":"\"wo//rking" }`),
validHash: b("{\"foo\": # this is a single line comm\\\"ent\n\"bar foo\", \"true\": false, \"number\": 42, \"object\": { \"test\": \"done\" }, \"array\" : [1, 2, 3], \"url\" : \"https://github.com\", \"escape\":\"\\\"wo//rking\" }"),
invalidHash: b(`{"foo": # this is a single line comment "bar foo", "true": false, "number": 42, "object": { "test": "done" }, "array" : [1, 2, 3], "url" : "https://github.com", "escape":"\"wo//rking" }`),
Expand Down
232 changes: 116 additions & 116 deletions translator.go
Original file line number Diff line number Diff line change
@@ -1,116 +1,116 @@
// MIT License

// Copyright (c) 2019 Muhammad Muzzammil

// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:

// The above copyright notice and this permission notice shall be included in all
// copies or substantial portions of the Software.

// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.

package jsonc

const (
ESCAPE = 92
QUOTE = 34
SPACE = 32
TAB = 9
NEWLINE = 10
ASTERISK = 42
SLASH = 47
HASH = 35
)

func translate(s []byte) []byte {
var (
i int
quote bool
escaped bool
)
j := make([]byte, len(s))
comment := &commentData{}
for _, ch := range s {
if ch == ESCAPE || escaped {
if !comment.startted {
j[i] = ch
i++
}
escaped = !escaped
continue
}
if ch == QUOTE {
quote = !quote
}
if (ch == SPACE || ch == TAB) && !quote {
continue
}
if ch == NEWLINE {
if comment.isSingleLined {
comment.stop()
}
continue
}
if quote && !comment.startted {
j[i] = ch
i++
continue
}
if comment.startted {
if ch == ASTERISK && !comment.isSingleLined {
comment.canEnd = true
continue
}
if comment.canEnd && ch == SLASH && !comment.isSingleLined {
comment.stop()
continue
}
comment.canEnd = false
continue
}
if comment.canStart && (ch == ASTERISK || ch == SLASH) {
comment.start(ch)
continue
}
if ch == SLASH {
comment.canStart = true
continue
}
if ch == HASH {
comment.start(ch)
continue
}
j[i] = ch
i++
}
return j[:i]
}

type commentData struct {
canStart bool
canEnd bool
startted bool
isSingleLined bool
endLine int
}

func (c *commentData) stop() {
c.startted = false
c.canStart = false
}

func (c *commentData) start(ch byte) {
c.startted = true
c.isSingleLined = ch == SLASH || ch == HASH
}
// MIT License

// Copyright (c) 2019 Muhammad Muzzammil

// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:

// The above copyright notice and this permission notice shall be included in all
// copies or substantial portions of the Software.

// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.

package jsonc

const (
ESCAPE = 92
QUOTE = 34
SPACE = 32
TAB = 9
NEWLINE = 10
ASTERISK = 42
SLASH = 47
HASH = 35
)

func translate(s []byte) []byte {
var (
i int
quote bool
escaped bool
)
j := make([]byte, len(s))
comment := &commentData{}
for _, ch := range s {
if ch == ESCAPE || escaped {
if !comment.startted {
j[i] = ch
i++
}
escaped = !escaped
continue
}
if ch == QUOTE && !comment.startted {
quote = !quote
}
if (ch == SPACE || ch == TAB) && !quote {
continue
}
if ch == NEWLINE {
if comment.isSingleLined {
comment.stop()
}
continue
}
if quote && !comment.startted {
j[i] = ch
i++
continue
}
if comment.startted {
if ch == ASTERISK && !comment.isSingleLined {
comment.canEnd = true
continue
}
if comment.canEnd && ch == SLASH && !comment.isSingleLined {
comment.stop()
continue
}
comment.canEnd = false
continue
}
if comment.canStart && (ch == ASTERISK || ch == SLASH) {
comment.start(ch)
continue
}
if ch == SLASH {
comment.canStart = true
continue
}
if ch == HASH {
comment.start(ch)
continue
}
j[i] = ch
i++
}
return j[:i]
}

type commentData struct {
canStart bool
canEnd bool
startted bool
isSingleLined bool
endLine int
}

func (c *commentData) stop() {
c.startted = false
c.canStart = false
}

func (c *commentData) start(ch byte) {
c.startted = true
c.isSingleLined = ch == SLASH || ch == HASH
}

0 comments on commit 9d456f0

Please sign in to comment.