Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes from new react compiler eslint plugin #3562

Merged
merged 3 commits into from
May 21, 2024
Merged

Some fixes from new react compiler eslint plugin #3562

merged 3 commits into from
May 21, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented May 17, 2024 •
edited

  • Fix mutating props, clean up the whole logic
  • Fix Select being forced on full width
  • Fix updating ref in SelectOptions, just use controlled state
  • Fix formState updates. Never disable react eslint rules
  • Fix @toolpad/core dev command clearing the screen
  • Fix the @toolpad/core dev command (cc @apedroferreira best to always avoid & in npm scripts. It doesn't handle exceptions and kill signals well)

@Janpot Janpot added the core Infrastructure work going on behind the scenes label May 17, 2024
@Janpot Janpot changed the title Some fixes from new react eslint plugin Some fixes from new react compiler eslint plugin May 17, 2024
@Janpot Janpot marked this pull request as ready for review May 17, 2024 11:26
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 20, 2024
@Janpot
Merge branch 'master' into react-compiler
36db7be 
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
@Janpot Janpot enabled auto-merge (squash) May 21, 2024 07:36
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 21, 2024
@Janpot Janpot merged commit 282d1b7 into mui:master May 21, 2024
12 checks passed
@Janpot Janpot deleted the react-compiler branch May 21, 2024 07:54
@aarongarciah aarongarciah mentioned this pull request Jun 6, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Janpot @apedroferreira