Add spacing between elements #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // If mesure width is too small, staff lines don't fill the whole panel | ||
| // So we redraw them until all the panel is covered | ||
| qreal staffWidth = e->width(); | ||
| while (staffWidth < _width - _heightName * 1.5) { |
There was a problem hiding this comment.
looks hacky. Coudn't we do the same than you did for other elements, recreating it and make it the right width ?
There was a problem hiding this comment.
Yeah, I admit. My idea was to avoid consuming CPU time by creating a new element, then deleteting it. But now updated my pull request. I clone the StaffLines then change it's width. More elegant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use MuseScore Styles to add spacing between elements.
Also fix the staff lines that sometimes didn't fill all the panel when a measure was to narrow.