Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change mscore.exe to MuseScore2.exe #1256

Closed
wants to merge 1 commit into from

Conversation

Jojo-Schmitz
Copy link
Contributor

to diffentiate better from a possible parallel installation of MuseScore 1.x

I have not yet managed to get it to create an mscore.exe though, any hints?

@AntonioBL
Copy link
Contributor

I think you should modify mscore\CMakeLists.txt to change the name of the application. Lines 197-208 variable "ExecutableName".

@Jojo-Schmitz
Copy link
Contributor Author

Hmm, thanks, but this isn't it, not alone at least (and I hadn't found that spot because I was searching for 'mscore.exe', stupid me). But there is MSCORE_OUTPUT_NAME, found thanks to your hint.
Let's try...

OK, using this in QtCreator for the cMake step, along with a change what exe to run works for me:
-DCMAKE_BUILD_TYPE=DEBUG -DCMAKE_TOOLCHAIN_FILE=build/mingw32.mingw.cmake -DCMAKE_INSTALL_PREFIX=../win32install -DMSCORE_OUTPUT_NAME=mscore2

@thomasbonte
Copy link
Contributor

Why not make it musescore2.exe

@Jojo-Schmitz Jojo-Schmitz changed the title change mscore.exe to mscore2.exe change mscore.exe to MuseScore2.exe Sep 1, 2014
@Jojo-Schmitz
Copy link
Contributor Author

OK, it is MuseScore2.exe now...

to diffentiate better from a possible parallel installation of MuseScore
1.x. To build in QtCreator add "-DMSCORE_OUTPUT_NAME=MuseScore2" to the
cMake command line and ajdust the project to run MuseScore2.exe (rather
than mscore.exe).
@mgavioli
Copy link
Contributor

Would it not be the case to change to MuseScore2 the name of the executable on other platforms too?

@Jojo-Schmitz
Copy link
Contributor Author

Probably, I just wouldn't know how and where and can't test it.

@chenlung
Copy link
Contributor

(I don't have a big understanding of this, so bare with me if I miss anything.)

I think it should be just musescore.exe (or maybe MuseScore.exe), leaving mscore.exe for the 1.x series.

From what I remember of observations, versions numbers don't tend to be included in file names, although it might present a problem if we didn't do so - e.g. the user retains 2.0 and has the upgrade (e.g. to 2.1, or 3.0) installed alongside. It might be deviating, but wouldn't an automatic uninstall occur when installing the new version anyway (or either 'forced', or 'recommended')? Maybe there is a setting in order to have both installed.

It should perhaps all be lower case too - I can't really think of mixed case examples (please correct if wrong). Is there a custom in command lines to input using the former?

@Jojo-Schmitz
Copy link
Contributor Author

MuseScore.exe or musescore.exe, for Windows this is just cosmetic, as here the file systems are not case sensitive, just case preserving. And so far this PR is Windows only.
I'd expect a MuseScore 2.1 to not coexists with a 2.0, but would expect 2.x to coexist with 3.x, just like 1.x does with 2.0.
It is too late to do any renaming for 1.x, but to be safe from collisions with a 3.x, MuseScoreX.exe, with X being the major version, might make sense?

@chenlung
Copy link
Contributor

My primary OS is now Mac, but it used to be Windows - I sometimes pop on the PC. :)

@Jojo-Schmitz
Copy link
Contributor Author

Or maybe just mscore for Linux/Mac and mscore.exe for Windows for 1.x, but mscoreX for Linux/Mac and mscoreX.exe for Windows? Again with X being the major version, of course.
I guess the more important part is to make the desktop icons and entries in the start menus of the various OSs different enough, also the 'open with' dialog (at least on Windows), so users can tell them apart.

@lasconic
Copy link
Contributor

lasconic commented Dec 8, 2014

See 03bf869

@lasconic lasconic closed this Dec 8, 2014
@Jojo-Schmitz Jojo-Schmitz deleted the packaging branch December 8, 2014 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants