Fix #20826 - Numpad numbers no longer work to select note duration. #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed by blocking the creation (and pooling) of QAction creation for shortcuts with multiple alternatives in different states (like the 'common' and TAB-specific variants of "pad-note-..." shortcuts) A rather detailed description of the implementation (regarding both the original, faulty, implementation and this fix) has been added to the mscore/shortcut.h file
|
It works as advertised but going to Edit -> Preferences crashes MuseScore |
|
Thanks for testing! Should be fixed now. |
|
UPDATE: the current implementation messes with the NumPad modifier code when saving and loading (customized) shortcuts, as QKeySequence does not supports the Qt::NumPadModifier (only QKeyEvent does). More work in progress... |
…sequences both in dlg boxes and in xml files. Also allows to remove the <code> tag from shortcuts.xml
mgavioli
added a commit
that referenced
this pull request
Apr 29, 2013
…shortcuts Fix #20826 - Numpad numbers no longer work to select note duration.
heuchi
pushed a commit
to heuchi/MuseScore
that referenced
this pull request
Nov 13, 2013
…duration_shortcuts Fix musescore#20826 - Numpad numbers no longer work to select note duration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20826
Fixed by blocking the creation (and pooling) of QAction creation for shortcuts with multiple alternatives in different states (like the 'common' and TAB-specific variants of "pad-note-..." shortcuts).
A rather detailed description of the implementation (regarding both the original, faulty, implementation and this fix) has been added to the mscore/shortcut.h file.
See: http://musescore.org/en/node/20826
Addendum: added support for "NumPad+" qualifier in textual representations of key sequences (both in dlgs and in shortcuts.xml), removing the need for the <code> tag in shortcuts.xml.