Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop playback update and improvements #451

Merged
merged 4 commits into from
Aug 26, 2013
Merged

Conversation

vgstef
Copy link
Contributor

@vgstef vgstef commented Aug 23, 2013

Different changes :

  • Fix the loop shortcuts states to avoid being active in edit mode/lyrics
  • Moved the loop In/Out positions in score instead of Scoreview
  • Add loop on selection
  • Change the way the shortcuts work (no checkable state for the loop In/Out buttons)
  • Revert to the previous way of inserting the ME_LOOP event (using lower_bound causes a segmentation fault)

@lasconic
Copy link
Contributor

In seq.cpp; the loop events somehow has to be processed before the first note on event to avoid noise. Maybe a better solution would be to handle it in process() by sorting midi events of same tick.

lasconic added a commit that referenced this pull request Aug 26, 2013
Loop playback update and improvements
@lasconic lasconic merged commit 82ef459 into musescore:master Aug 26, 2013
heuchi pushed a commit to heuchi/MuseScore that referenced this pull request Nov 13, 2013
Loop playback update and improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants