Colon-delimited search path for templates #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* template_path can be a colon-delimited list
* To facilitate testing with Gollum
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to customize just the layout template in Gollum, but since the template directory you can pass in must contain all templates, I wound up having to copy all the templates from the Gollum gem into my own template directory. In order to make this DRYer I changed Gollum to prepend the custom directory to the gem directory with a colon delimiter, then updated Mustache to accept a template_path containing colons and do a search for templates. This fixes issue #154
Note that I bumped the version to 1.0.6 to ease in testing my Gollum setup.