Fix test race condition. #258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test suite randomly fails with errors such as: ~~~ 1) Failure: AutoloadingTest#test_autoload_lowercase [/builddir/build/BUILD/mustache-1.1.1/usr/share/gems/gems/mustache-1.1.1/test/autoloading_test.rb:17]: Expected: Comments Actual: nil ~~~ This happens when `test_namespaced*` test cases are executed earlier than the remaining test cases, because they are defining `view_namespace` but not cleaning up afterwards.
|
This can be reproduced by running test suite as: I am bit surprised, that this probably never happened when running the test suite via Rake. |
|
The CI error does not seem to be specific to this PR. |
|
Also, it seems that this issue started to appear since testing against Ruby 2.7. Not sure what should be different, except Minitest version (which could influence test order). |
|
This seems to fix random test failures, seen on Debian: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite randomly fails with errors such as:
This happens when
test_namespaced*test cases are executed earlierthan the remaining test cases, because they are defining
view_namespacebut not cleaning up afterwards.