forked from elastic/elasticsearch
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Handle optional term and field statistics gracefully
Lucene provides a set of statistics that depend on the codec / postingsformat as well as on the index options used when the field is created / indexed. If a certain stats value is not available lucene return `-1` instead of the correct value. We need to ensure that those values are encoded correctly if we try to write vLongs as well as when we aggregate those values. Closes elastic#3012
- Loading branch information
Showing
6 changed files
with
343 additions
and
97 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /* | ||
| * Licensed to ElasticSearch and Shay Banon under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. ElasticSearch licenses this | ||
| * file to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.elasticsearch.common.collect; | ||
|
|
||
| import gnu.trove.impl.Constants; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| import org.elasticsearch.ElasticSearchIllegalArgumentException; | ||
| import org.elasticsearch.common.trove.ExtTHashMap; | ||
|
|
||
| import com.google.common.collect.ForwardingMap; | ||
|
|
||
| /** | ||
| * This class provides factory methods for Maps. The returned {@link Map} | ||
| * instances are general purpose maps and non of the method guarantees a | ||
| * concrete implementation unless the return type is a concrete type. The | ||
| * implementations used might change over time, if you rely on a specific | ||
| * Implementation you should use a concrete constructor. | ||
| */ | ||
| public final class XMaps { | ||
|
|
||
| public static final int DEFAULT_CAPACITY = Constants.DEFAULT_CAPACITY; | ||
|
|
||
| /** | ||
| * Returns a new map with the given initial capacity | ||
| */ | ||
| public static <K, V> Map<K, V> newMap(int capacity) { | ||
| return new ExtTHashMap<K, V>(capacity, Constants.DEFAULT_LOAD_FACTOR); | ||
| } | ||
|
|
||
| /** | ||
| * Returns a new map with a default initial capacity of | ||
| * {@value #DEFAULT_CAPACITY} | ||
| */ | ||
| public static <K, V> Map<K, V> newMap() { | ||
| return newMap(DEFAULT_CAPACITY); | ||
| } | ||
|
|
||
| /** | ||
| * Returns a map like {@link #newMap()} that does not accept <code>null</code> keys | ||
| */ | ||
| public static <K, V> Map<K, V> newNoNullKeysMap() { | ||
| Map<K, V> delegate = newMap(); | ||
| return ensureNoNullKeys(delegate); | ||
| } | ||
|
|
||
| /** | ||
| * Returns a map like {@link #newMap(in)} that does not accept <code>null</code> keys | ||
| */ | ||
| public static <K, V> Map<K, V> newNoNullKeysMap(int capacity) { | ||
| Map<K, V> delegate = newMap(capacity); | ||
| return ensureNoNullKeys(delegate); | ||
| } | ||
|
|
||
| /** | ||
| * Wraps the given map and prevent adding of <code>null</code> keys. | ||
| */ | ||
| public static <K, V> Map<K, V> ensureNoNullKeys(final Map<K, V> delegate) { | ||
| return new ForwardingMap<K, V>() { | ||
| @Override | ||
| public V put(K key, V value) { | ||
| if (key == null) { | ||
| throw new ElasticSearchIllegalArgumentException("Map key must not be null"); | ||
| } | ||
| return super.put(key, value); | ||
| } | ||
|
|
||
| @Override | ||
| protected Map<K, V> delegate() { | ||
| return delegate; | ||
| } | ||
| }; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.