Two fixes to avoid matplotlib osx backend issues #546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately this causes issues with the |
|
Hm, also there is some weird issue such that the legend does not immediately appear when the gui window pops up, but it does show up if the window is resized. |
Merged
|
Closing in favor of #611 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes some things in
FacetGridandheatmapto avoid two common and very annoying issues caused by the the matplotlib osx backend.I believe this is the root matplotlib issue: matplotlib/matplotlib#2654
This has come up a few times in seaborn: #545, #408, #231, and elsewhere.
The fix to
FacetGridshould, I believe, simply make that work. The fix toheatmapis a compromise where the exception that is raised when trying to determine if the ticklabels overlap gets caught and the labels are not rotated. That means that the plots might not look as good for everyone, but this feels better than the plot simply not working.I haven't tested this extensively, but I seem to be able to plot using the OSX backend without running into these common issues.