Skip to content

Conversation

fibbers
Copy link

@fibbers fibbers commented Aug 8, 2024

When collecting tracing information via OpenTelemetry, I saw unexpected Rollback spans which I couldn't explain.
Following the source, it seems it should have indeed been a Commit span, so correct that in this PR.

I'm using:

<dependency>
	<groupId>com.mysql</groupId>
	<artifactId>mysql-connector-j</artifactId>
	<version>8.4.0</version>
</dependency>

Notes:

  • I just signed the OCA, I believe it's under review currently
  • I tried searching for tests, but couldn't find any, so I hope my PR is complete this way
  • this PR only addresses the version I use (8.4.0), I hope it can be cherry-picked to other releases as well if necessary

@mysql-oca-bot
Copy link

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/
Please make sure to include your MySQL bug system user (email) in the returned form.
Thanks

@fibbers
Copy link
Author

fibbers commented Aug 15, 2024

Hi, the OCA was just approved. I linked my GitHub username in there, so I hope everything's correct now.

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment:
"I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it."
Thanks

@fibbers
Copy link
Author

fibbers commented Aug 15, 2024

I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow
bug http://bugs.mysql.com/bug.php?id=115845 for updates.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants