Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SyntaxRegressionTest.java #96

Closed
wants to merge 3 commits into from
Closed

Conversation

abbytec
Copy link

@abbytec abbytec commented Apr 30, 2023

Some test methods are private, by default JUnit5 ignores private methods with @test annotation.
So @test is unnecesary there. References:
https://rules.sonarsource.com/java/tag/junit/RSPEC-5810

testJsonTypeCheckFunction is private, by default JUnit5 ignores private methods. So @test is unnecesary there.
References:
https://rules.sonarsource.com/java/tag/junit/RSPEC-5810
Removed unnecesary @test
By default, JUnit5 ignore those tests
References: https://rules.sonarsource.com/java/tag/junit/RSPEC-5810
By default, JUnit5 ignore privated method with @test annotations, so it's unnecesary there.
References: https://rules.sonarsource.com/java/tag/junit/RSPEC-5810
@mysql-oca-bot
Copy link

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/
Please make sure to include your MySQL bug system user (email) in the returned form.
Thanks

@abbytec
Copy link
Author

abbytec commented May 1, 2023

Done! 😊

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment:
"I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it."
Thanks

@abbytec
Copy link
Author

abbytec commented May 15, 2023

I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow
bug http://bugs.mysql.com/bug.php?id=111031 for updates.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants