Update command.cs #7
Conversation
Currently if MySqlCommand was asynchronously executed with a CancellationToken, and that token is cancelled After the command is disposed, the MySqlCommand throws NullReferenceException because at that point command's connection is null. This is OK for release builds because the exception would be caught by System.Data.Common.DbCommand's internal logic, but it is very annoying to see these exceptions when debugging. Additionally, it ads extra unnecessary overhead of throwing/catching an exception. The fix is simply to check whether connection is null before calling CancelQuery.
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html |
|
done
2017-06-15 14:48 GMT+03:00 mysql-oca-bot <notifications@github.com>:
… Hi, thank you for submitting this pull request. In order to consider your
code we need you to sign the Oracle Contribution Agreement (OCA). Please
review the details and follow the instructions at http://www.oracle.com/
technetwork/community/oca-486395.html
Please make sure to include your MySQL bug system user (email) in the
returned form.
Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ARTYcuaWGIDRdj3ANAzwTVYyQpWrmnYJks5sERoggaJpZM4N7DXx>
.
|
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
|
Thank you for your contribution that has been added to 8.0.22: https://lefred.be/content/mysql-8-0-22-thank-you-for-the-contributions/ |
Currently if MySqlCommand was asynchronously executed with a CancellationToken, and that token is cancelled After the command is disposed, the MySqlCommand.Cancel() throws NullReferenceException because at that point command's connection is null. This is OK for release builds because the exception would be caught by System.Data.Common.DbCommand's internal logic, but it is very annoying to see these exceptions when debugging. Additionally, it ads extra unnecessary overhead of throwing/catching an exception. The fix is simply to check whether connection is null before calling CancelQuery.