Warning behaviour improvements #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Warnings now propagated using warnings module when get_warnings is set (raise_on_warnings behaves the same as before) - Do not disable get_warnings if raise_on_warnings is explicitly set to False - errors.Warning subclasses Warning - errors.get_mysql_exception can now return warnings where appropriate - cursor_[cext].handle_warnings now also emits warnings, not just exceptions - Ignore "unread result" exception in cursor[_cext].close() - connection.close() does not leak socket if cmd_quit fails
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear mysql connector team,
Here are some improvements to the way warnings work in the library, for your consideration, as well as a couple of
close()-handling ones. (Apologies for that not being a separate commit due to time constraints.)get_warningsis set(
raise_on_warningsbehaves the same as before)This I think might be useful since warnings are immediately visible, especially during development.
Given (1) I think this makes sense
errors.WarningsubclassesWarningPrerequisite for (1)
4.
errors.get\_mysql\_exceptioncan now return warnings where appropriatePrerequisite for (1)
Prerequisite for (1)
cursor[_cext].close()If one e.g. calls
cursor.execute(...)(unbuffered) and during looping over the result set an sql-unrelated exception occurs, duringcursor.close()(e.g. viafinallyclause) the original exception will be override by the "unread result" one. I think it might make more sense to silence this exception when closing the cursor.connection.close()does not leak socket ifcmd_quitfails2nd statement in try-except closes socket, but might not be reached if
cmd_quitfails first. Have each in their own try-except instead.