Fix incorrect passing of argument to mysql_options #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that it would appear arguments for some
mysql_options
calls are not being passed as documented in that they are absolute values rather than references! I noticed this from gcc warnings, e.g.:Additionally,
SSL_MODE_DISABLED
is being used as an argument forMYSQL_OPT_SSL_ENFORCE
, where it appears it should actually beMYSQL_OPT_SSL_MODE
.