Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

followup fix for BUG29855733, reserved filed should be with length 22 now #52

Closed
wants to merge 1 commit into from

Conversation

GuuBu
Copy link

@GuuBu GuuBu commented Sep 3, 2019

After commit d4f740e, MySQL connector python driver is broken to connect with Azure MySQL server. From MySQL Protocol::SSLRequest: , and commit d4f740e, the length of the reserved field should be 22 now.

@mysql-oca-bot
Copy link

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html
Please make sure to include your MySQL bug system user (email) in the returned form.
Thanks

@GuuBu
Copy link
Author

GuuBu commented Sep 3, 2019 via email

@GuuBu
Copy link
Author

GuuBu commented Sep 4, 2019

Hi,

I've assigned OCA. Can you help review my change? Thanks.

Best Regards,
Qianqian Bu

@GuuBu
Copy link
Author

GuuBu commented Sep 4, 2019

Hi @nmariz
Recently I find the latest version 8.0.17 does not work with Azure MySQL server with error that the connection string may not be right. After check, I find this should relate to commit d4f740e which has changed the charset field to 2 bytes. I think then the remaining field should be with length 22 instead of 23, is this right? Can you help review? Thanks.

Best Regards,
Qianqian Bu

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment:
"I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it."
Thanks

@GuuBu
Copy link
Author

GuuBu commented Sep 5, 2019

I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow
bug http://bugs.mysql.com/bug.php?id=96770 for updates.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants