Fix executemany batch insert operations sentinel RE #81
Conversation
…rt-operations-sentinel-re Fix executemany batch insert operations sentinel RE
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/ |
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
|
This bug is still present in version 8.0.31. |
The
MySQLCursor.executemany()method implements a sentinel for detecting batch insert operations and grouping multipleINSERTqueries into a significantly more performant singleINSERTquery with multiple values.The current definition of the RE is faulty, causing the sentinel to fail in correctly identifying batch
INSERToperations. This fault seems to be due to a regression introduced in ddf6b13, released as part of v8.0.30.As can be seen in diff#ddf6b13, while the
.format()invocation was removed from cursor.py#L52, the escaping curly braces for the RE quantifier defined were left behind. Lacking the.format()invocation the previously escaping curly braces to the RE quantifier now defined at lib/mysql/connector/cursor.py#L59 have become part of the RE itself, thus breaking the sentinel to always fail identifying batchINSERToperations.This PR fixes the above described regression. The associated MySQL issue tracker bug: https://bugs.mysql.com/bug.php?id=108145&thanks=2¬ify=195