-
Notifications
You must be signed in to change notification settings - Fork 143
Fix build.sh: shebang MUST be on the first line! #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It may be time to modify this to include 2022 in the copyright but I'll leave that up to you to do if appropriate given copyright notices and years tend to be decided/managed by the owners. |
Neither https://github.com/mysql/mysql-operator nor https://dev.mysql.com/doc/mysql-operator/en/ make any comments about how to contribute or provide PRs such as this to this repo. While I understand my proposed patch is tiny it always helps to have explicit information which clarifies the right way to offer PRs:
From my perspective I offer my PR under the UPL 1.0 stated above to match existing code. |
Similarly there seems to be no way to provide feedback to you on the code you are developing or how to use it which is unfortunate. The information provided at https://dev.mysql.com/doc/mysql-operator/en/ mentions forums:
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
So I guess I got my answer to above. The OCA is not quite the same as saying you offer this under the UPL 1.0 so it would be good to clarify this in the documentation for making a PR. |
Note: it would also be good for the bot to provide a link to the OCA and also to the process to set one up if it has not been done before. Modifying the default comment it emits should be simple enough to do that, and I guess this should apply to all github repos where the mysql-oca-bot is present. |
Hi @sjmudd Thanks for your contribution and feedback. Please note:
Thanks again for contributing to MySQL |
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
The
#!/bin/bash
MUST be on the first line.by adding the copyright notice above the shebang the shell will not be executed correctly.