Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

Conversation

svagner
Copy link

@svagner svagner commented Apr 23, 2016

There are 2 bugs:

  1. When router tries to write to the closed socket, it gets signal SIGPIPE. The program will be terminated by default in this case (watch man 7 signal). To represent a bug at GNU Linux OS:
  • run mysqlrouter with routing at some port (ex. 7001)
  • run telnet to the port and terminate it without any inputs with Ctrl+C
  1. We don't cleanup a map with blocks notation (MySQLRouting::auth_error_counters_ (private)). If we have some problems at client side (or may be we check port without normal termination of socket or etc.) we block this client for perpetuity (client will be unblocked only if mysqlproxy restarts). But with the production system it is imposible. To represent a bug:
  • set max_connect_errors to 1
  • run mysqlrouter with routing at some port (ex. 7001)
  • run telnet to mysqlrouter port and exit from telnet normally
  • run telnet again...

I've added option max_connect_errors_timeout to the routing plugin. This option doesn't affect to current behavior when it is set to 0 (we don't need to unblock clients).

@mysql-oca-bot
Copy link

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html
Please make sure to include your MySQL bug system user (email) in the returned form.
Thanks

@svagner
Copy link
Author

svagner commented Apr 25, 2016

Thanks! I've sent it.

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment:
"I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it."
Thanks

@svagner
Copy link
Author

svagner commented May 20, 2016

I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow
bug http://bugs.mysql.com/bug.php?id=81548 for updates.
Thanks

@emkookmer
Copy link

I have the same problem as described here, what is the merge status ?

@emkookmer
Copy link

@geertjanvdk @bkandasa @amitab @mysql-oca-bot Can this be merged ?

bkandasa pushed a commit that referenced this pull request Apr 12, 2017
The issues #1 and #2 from this bug are already addressed with other fixes
[Fix for Bug #25682736 LINUX BOOTSTRAP GENERATED CONFIG FILE SHOULD BE WORLD
 READABLE)

Issue #3 is no longer relevant as --master-key-file options has been removed
but there was still a reference to it in the user facing output.
Removed this reference as a fix.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants