Innodb: innodb_numa_interleave=1, use numa numa_get_mems_allowed #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using numa_all_nodes_ptr was excessively optimistic. Due to constraints in systemd, containers or otherwise mysqld could of been limited to a smaller set of cpus. Use the numa_get_mems_allowed library function to see what we can interleave between before doing so. Signed-off-by: Daniel Black <daniel.black@au.ibm.com>
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
gunnarku
pushed a commit
to facebook/mysql-8.0
that referenced
this pull request
Jul 21, 2017
Summary: MyRocks did strict dictionary consistency check that newer index_id (passed by CREATE TABLE) must be larger than max_index_id stored in data dictionary. This is not always true. Suppose the following conditions. CREATE TABLE t1: 1) index_id= ddl_manager.get_next_number(); 4) dict_manager.update_max_index_id(batch, index_id) CREATE TABLE t2: 2) index_id= ddl_manager.get_next_number(); 3) dict_manager.update_max_index_id(batch, index_id) MyRocks returned an error on CREATE TABLE t1 because of dictionary condition check (dict_manager.update_max_index_id()). Then MyRocks crashed later by memory violation, because ddl_manager.put_and_write() was not cleaned up after failure. This diff fixes the issue by updating max_index_id in dictionary when getting new index id. This diff also renaming function name from ddl_manager.get_next_number() to ddl_manager.get_and_update_next_number(). Test Plan: mtr Reviewers: maykov, spetrunia, jkedgar, hermanlee4 Reviewed By: hermanlee4 Differential Revision: https://reviews.facebook.net/D45963
gunnarku
pushed a commit
to facebook/mysql-8.0
that referenced
this pull request
Jul 25, 2017
Summary: MyRocks did strict dictionary consistency check that newer index_id (passed by CREATE TABLE) must be larger than max_index_id stored in data dictionary. This is not always true. Suppose the following conditions. CREATE TABLE t1: 1) index_id= ddl_manager.get_next_number(); 4) dict_manager.update_max_index_id(batch, index_id) CREATE TABLE t2: 2) index_id= ddl_manager.get_next_number(); 3) dict_manager.update_max_index_id(batch, index_id) MyRocks returned an error on CREATE TABLE t1 because of dictionary condition check (dict_manager.update_max_index_id()). Then MyRocks crashed later by memory violation, because ddl_manager.put_and_write() was not cleaned up after failure. This diff fixes the issue by updating max_index_id in dictionary when getting new index id. This diff also renaming function name from ddl_manager.get_next_number() to ddl_manager.get_and_update_next_number(). Test Plan: mtr Reviewers: maykov, spetrunia, jkedgar, hermanlee4 Reviewed By: hermanlee4 Differential Revision: https://reviews.facebook.net/D45963
dbussink
pushed a commit
to planetscale/mysql-server
that referenced
this pull request
Mar 6, 2024
…ysql#104) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using numa_all_nodes_ptr was excessively optimistic. Due to
constraints in systemd, containers or otherwise MySQL could of been
limit to a smaller set of cpus. Use the numa_get_mems_allowed
library function to see what we can interleave between before doing
so.
Signed-off-by: Daniel Black daniel.black@au.ibm.com