NDB: Disallow connect string to start with '/' #204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One can easily use -c to specify the config file by mistake. -c is connect-string. -f is config file. Confusing these is bad enough, but ndb_mgmd often accepts a bogus value for the -c option (e.g -c /etc/ndb/config.ini)
dveeden
changed the title
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One can easily use -c to specify the config file by mistake.
-c is connect-string. -f is config file.
Confusing these is bad enough, but ndb_mgmd often accepts a
bogus value for the -c option (e.g -c /etc/ndb/config.ini)
This commit only works if the -c option gets a full path, it won't work for relative paths. Feel free to throw my commit away and implement a different fix for this issue.