Call processor in visit_item for FUNC_ITEM #252
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use case:
Be able to use a post-parse plugin that acts on specific functions being called.
This is done by just adding
FUNC_ITEM
to the list.However multiple comments seem to indicate that visit function is only called for literals.
The solutions I see are:
parse_node_visit_function
etc. have generic names, so to make this clean these then have to be renamed to something likepare_node_visit_literal_function
etc.FUNC_ITEM
and any other item when needed. That's what is in this pull request.Please let me know if you think this is a good solution or if there is a better or cleaner solution.