Calculating columns sizes based on the character set in mysql client #267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, print_table_data calculates the size of the column as a length of its longest value in bytes (or of its name, if it is longer).
This results in output with additional spaces for multibyte strings. (for utf8, a column can be 2-4 times larger than its longest value).
In this patch column size is calculated based on the character set which client uses.
How to reproduce:
select 'ⲫ' as x;
Output:
Expected output: