Update SQL modes in the comments in statements_event.h #367
Conversation
Although a list of appropriate references is provided, existing comments may still leave room for confusion. Some sytem variables is reserved with outdated value. The comment is updated to prevent any misunderstanding.
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/ |
|
I've reviewed and signed OCA. |
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
|
@dongwook-chan Hi, have you tracked whether your patch is merged or not ? I don't see it in 8.0. When does community merge this kind of external PR ? |
|
@baiwfg2 |
|
Sigh .. |
Existing comments int statements_event.h provides outdated values for sql mode system variables.
This PR updates the values and adds new variables to prevent confusion.