Fix memory leak when host_cache_size is 0. #378
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL version:
mysql Ver 14.14 Distrib 5.7.32, for Linux (x86_64) using EditLine wrapper
Background:
As described in the documentation, we set
host_cache_size
to 0 instead of--skip-host-cache
.But after a long run, we found a serious memory leak. Here is the valgrind log:
Reason:
While
host_cache_size
is 0,hostname_cache->add(entry)
will always fail, but we did not free memory of entry.