rpcgen.cmake: always build xdr_sizeof.c on macOS #386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The availability of xdr_sizeof() is dependent on the macOS version, not the compiler version; xdr_sizeof() was provided by macOS 10.13 and earlier through the libsystem_info.dylib system library. Rather than adjusting the check to reflect this, xdr_sizeof.c can be built unconditionally on macOS, since MySQL has dropped support for macOS 10.13 and earlier.
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The availability of
xdr_sizeof()is dependent on the macOS version, not the compiler version;xdr_sizeof()was provided by macOS 10.13 and earlier through the libsystem_info.dylib system library. Rather than adjusting the check to reflect this, xdr_sizeof.c can be built unconditionally on macOS, since MySQL has dropped support for macOS 10.13 and earlier as of 2020-01-13: https://www.mysql.com/support/eol-notice.html.