client/mysql: enable comments by default #443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA,
and that I am authorized to contribute it.
…On February 7, 2023 11:54:05 mysql-oca-bot ***@***.***> wrote:
Hi, thank you for your contribution. Please confirm this code is submitted
under the terms of the OCA (Oracle's Contribution Agreement) you have
previously signed by cutting and pasting the following text as a comment:
"I confirm the code being submitted is offered under the terms of the OCA,
and that I am authorized to contribute it."
Thanks—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
--commentsthe default for MySQL Client.Stripping comments was very useful to make the MySQL Query Cache get a higher hitrate. However with the query cache having been deprecated in 5.7.20 and removed in 8.0 this isn't needed anymore.
Having the comments sent to the server make them appear in the processlist which can make them more easy to identify. Making them available to routers and proxies allows those to make use of them for query routing and diagnostic purposes as well.