Skip to content

Conversation

hongdongjian
Copy link

THD Attributes register m_db/m_examined_row_count/m_row_count_func/m_sent_row_count

Copy link
Contributor

@gkodinov gkodinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also add (empty) switch cases in set to signify that these are taken but aren't settable.
And I'd consider some mtr or unit test.

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment:
"I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it."
Thanks

@hongdongjian hongdongjian force-pushed the audit-plugin-add-row-parameter-8.0 branch from 839adfa to c96a53f Compare April 7, 2023 16:57
@hongdongjian
Copy link
Author

I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

@hongdongjian
Copy link
Author

I'd also add (empty) switch cases in set to signify that these are taken but aren't settable. And I'd consider some mtr or unit test.

Thank you for your guidance. I have made the corresponding changes according to your advice. When you have time, could you please help me take a look and I look forward to your reply.

@hongdongjian hongdongjian changed the title THD Attributes register m_db/m_examined_row_count/m_row_count_func/m_sent_row_count THD Attributes register db/examined_row_count/row_count_func/sent_row_count Apr 7, 2023
@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow
bug http://bugs.mysql.com/bug.php?id=110635 for updates.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants