Bug #80058: Free creation_ctx in sp_load_for_information_schema where create_string fails #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng fails cppcheck --force -DDBUG_VOID_RETURN=return -"DDBUG_RETURN(a)=return a" sql/sp.cc [sql/sp.cc:2282]: (error) Memory leak: creation_ctx
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
grooverdan
changed the title
gunnarku
pushed a commit
to facebook/mysql-8.0
that referenced
this pull request
Jul 21, 2017
…in reverse CF Summary: Make ha_rocksdb::index_read_map() correctly handle find_flag=HA_READ_BEFORE_KEY. Explanation how it should be handled is provided in storage/rocksdb/rocksdb-range-access.txt Test Plan: mtr t/rocksdb_range.test, used gcov to check the new code is covered Reviewers: maykov, hermanlee4, jtolmer, yoshinorim Differential Revision: https://reviews.facebook.net/D35331
gunnarku
pushed a commit
to facebook/mysql-8.0
that referenced
this pull request
Jul 25, 2017
…in reverse CF Summary: Make ha_rocksdb::index_read_map() correctly handle find_flag=HA_READ_BEFORE_KEY. Explanation how it should be handled is provided in storage/rocksdb/rocksdb-range-access.txt Test Plan: mtr t/rocksdb_range.test, used gcov to check the new code is covered Reviewers: maykov, hermanlee4, jtolmer, yoshinorim Differential Revision: https://reviews.facebook.net/D35331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found during static analysis:
cppcheck --force -DDBUG_VOID_RETURN=return -"DDBUG_RETURN(a)=return a" sql/sp.cc
[sql/sp.cc:2282]: (error) Memory leak: creation_ctx
Also exists in 5.6 and 5.7