Fix linkage of 'gen_keyword_list' executable #460
Conversation
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/ |
|
The entire history of the 8.0 branch was rewritten… twice:
I'm hoping to get some clarification from Oracle on whether the repo will now be left as-is… once that's done I'll rebase the PR. |
dlenski
force-pushed
the
fix-linkage-of-gen_keyword_list-executable
branch
from
57116d4 to
9c2e553
Compare
In mysql@dcef29c, first tagged in mysql-8.0.33, the CMake build infrastructure for the libicu dependency was modified to declare a new 'ext::icu' alias (see 'cmake/icu.cmake'). The CMake LINK_LIBRARIES for the 'gen_keyword_list' executable were changed to use the new 'ext::icu' alias, but at the same time '${CMAKE_DL_LIBS}' was *removed* from its LINK_LIBRARIES. This built-in variable names the library that includes the dlopen/dlclose/dlsym functions, normally '-ldl' on POSIX systems (see https://cmake.org/cmake/help/latest/variable/CMAKE_DL_LIBS.html). As a result, 'gen_keyword_list' doesn't link correctly in a clean build, because those functions cannot be found. The exact introduction of the problem was at mysql@dcef29c#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR2229 All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.
dlenski
force-pushed
the
fix-linkage-of-gen_keyword_list-executable
branch
from
9c2e553 to
fdfc2cf
Compare
|
|
Hi, there was no response to our request to sign an OCA or confirm the code is submitted under the terms of the OCA. As such this request will be closed. |
|
This contribution is under the OCA signed by Amazon and covering submissions to the MySQL project. |
|
Hi @dlenski |
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
In dcef29c,
first tagged in mysql-8.0.33, the CMake build infrastructure for the libicu
dependency was modified to declare a new 'ext::icu' alias (see
'cmake/icu.cmake').
The CMake LINK_LIBRARIES for the 'gen_keyword_list' executable were changed
to use the new 'ext::icu' alias, but at the same time '${CMAKE_DL_LIBS}' was
removed from its LINK_LIBRARIES. This built-in variable names the library
that includes the dlopen/dlclose/dlsym functions, normally '-ldl' on POSIX
systems (see https://cmake.org/cmake/help/latest/variable/CMAKE_DL_LIBS.html).
As a result, 'gen_keyword_list' doesn't link correctly in a clean build,
because those functions cannot be found.
The exact introduction of the problem was at
dcef29c#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR2229