Set variables to PARENT_SCOPE in CMake functions #468
Conversation
1f2b9d6 replaces macros with functions, but in CMake functions have different scope and the variables set in the functions are not visible to the caller. The change breaks MySQL building with `WITH_ZLIB="system"` for the reason above (ZLIB_FOUND is not visible when returning from `FIND_SYSTEM_ZLIB()`). Setting the necessary variables to PARENT_SCOPE (equal to returning variables) solves this issue. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/ |
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
This contribution is under the OCA signed by Amazon and covering submissions to the MySQL project. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
|
After going through the Magical Internal Oracle/MySQL Blender™, this was eventually merged in MySQL 8.0.35 as 486fb15 |
1f2b9d6 replaces macros with functions, but in CMake functions have different scope and the variables set in the functions are not visible to the caller. The change breaks MySQL building with
WITH_ZLIB="system"for the reason above (ZLIB_FOUND is not visible when returning fromFIND_SYSTEM_ZLIB()).Setting the necessary variables to PARENT_SCOPE (equal to returning variables) solves this issue.