Fix sloppy home directory substitution in SSL tests #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MTR test files ssl_ca.test and ssl_crl.test both attempt to verify the absence of a bug relating to Unix home directory substitution, which involves replacing '~' as the leftmost pathname component with the value of the `HOME` environment variable. However, the tests do so by replacing *all* occurrences of the value of `HOME` with '~' in the absolute path `MYSQL_TEST_DIR`. This causes problems on systems where the value of `HOME` is a symlink. For example, if `HOME=/home/myusername` (a symlink to `/local/home/myusername`) and `PWD=/local/home/myusername/MySQL`, the test will end up attempting to use nonsensical broken paths such as `/local~/MySQL/*`. The solution is to ensure that the substitution occurs *only* at the beginning of the path, and when immediately followed by '/'.
|
Submitted under the terms of the Amazon MySQL OCA. |
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MTR test files
ssl_ca.testandssl_crl.testboth attempt to verify the absence of a bug relating to Unix home directory substitution, which involves replacing~as the leftmost pathname component with the value of theHOMEenvironment variable.However, the tests do so by replacing all occurrences of the value of
HOMEwith '~' in the absolute pathMYSQL_TEST_DIR.This causes problems on systems where the value of
HOMEis a symlink. For example, ifHOME=/home/myusername(a symlink to/local/home/myusername) andPWD=/local/home/myusername/MySQL, the test will end up attempting to use nonsensical broken paths such as/local~/MySQL/*.The solution is to ensure that the substitution occurs only at the beginning of the path, and when immediately followed by '/'.