Fix build if UNIV_ZIP_DEBUG is enabled #538
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the UNIV_ZIP_DEBUG is enabled during build, the build process may
fail with the error:
In function ‘bool buf_LRU_block_remove_hashed(buf_page_t*, bool, bool)’:
error: ‘struct buf_block_t’ has no member named ‘index’
((buf_block_t *)bpage)->index));
^~~~~
Because the 'index' field was moved from the buf_block_t structure to
the buf_block_t.ahi_t in the d7114b1 commit.
The second error appears in the page_delete_rec(). Since the
'page_zip' parameter was removed from the function, the assert checks
that are enabled in a case of UNIV_ZIP_DEBUG are failed. As there is
no such parameter in the page_delete_rec() function anymore the both
assertions are removed.
The commit fixes the both compilation errors.
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
UNIV_ZIP_DEBUGflag is enabled during build, the build process may fail with the error:Because the 'index' field was moved from the buf_block_t structure to the buf_block_t.ahi_t in the d7114b1 commit.
The second error appears in the
page_delete_rec(). Since thepage_zipparameter was removed from the function in the 85f9abf, the assert checks that are enabled in a case ofUNIV_ZIP_DEBUGare failed. As there is no such parameter in thepage_delete_rec()function anymore the both assertions are removed.The commit fixes the both compilation errors.