Ensure FTS auxiliary tables are cleaned up properly #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue here is that when multiple FTS indexes are dropped in a single `ALTER TABLE` statement, we don't clean up the auxiliary index tables from the data dictionary. They are still referenced and when MySQL restarts the next time, it prints a number of warnings: 2024-07-04T10:07:26.207208Z 1 [Warning] [MY-012351] [InnoDB] Tablespace 12, name 'test/fts_000000000000042d_00000000000000a7_index_1', file './test/fts_000000000000042d_00000000000000a7_index_1.ibd' is missing! 2024-07-04T10:07:26.207251Z 1 [Warning] [MY-012351] [InnoDB] Tablespace 13, name 'test/fts_000000000000042d_00000000000000a7_index_2', file './test/fts_000000000000042d_00000000000000a7_index_2.ibd' is missing! 2024-07-04T10:07:26.207285Z 1 [Warning] [MY-012351] [InnoDB] Tablespace 14, name 'test/fts_000000000000042d_00000000000000a7_index_3', file './test/fts_000000000000042d_00000000000000a7_index_3.ibd' is missing! 2024-07-04T10:07:26.207303Z 1 [Warning] [MY-012351] [InnoDB] Tablespace 15, name 'test/fts_000000000000042d_00000000000000a7_index_4', file './test/fts_000000000000042d_00000000000000a7_index_4.ibd' is missing! 2024-07-04T10:07:26.207319Z 1 [Warning] [MY-012351] [InnoDB] Tablespace 16, name 'test/fts_000000000000042d_00000000000000a7_index_5', file './test/fts_000000000000042d_00000000000000a7_index_5.ibd' is missing! 2024-07-04T10:07:26.207335Z 1 [Warning] [MY-012351] [InnoDB] Tablespace 17, name 'test/fts_000000000000042d_00000000000000a7_index_6', file './test/fts_000000000000042d_00000000000000a7_index_6.ibd' is missing! The problem is that when multiple indexes are dropped at once, we end up looping through and overwriting ctx->fts_drop_aux_vec on the next iteration. This means that this both leaks memory as the old vector is not de-allocated but also that the initial set of aux tables is not removed from the data dictionary later on. The fix is simple, only allocate ctx->fts_drop_aux_vec if it's not allocated yet. This way all aux tables are gathered for all indexes and cleaned up correctly. A test is added that reproduces the above warning and this test passes with the fixes here. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
shlomi-noach
approved these changes
Jul 4, 2024
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here is that when multiple FTS indexes are dropped in a single
ALTER TABLEstatement, we don't clean up the auxiliary index tables from the data dictionary. They are still referenced and when MySQL restarts the next time, it prints a number of warnings:The problem is that when multiple indexes are dropped at once, we end up looping through and overwriting
ctx->fts_drop_aux_vecon the next iteration.This means that this both leaks memory as the old vector is not de-allocated but also that the initial set of aux tables is not removed from the data dictionary later on.
The fix is simple, only allocate
ctx->fts_drop_aux_vecif it's not allocated yet. This way all aux tables are gathered for all indexes and cleaned up correctly.A test is added that reproduces the above warning and this test passes with the fixes here.