Skip to content

Fix for resetting innodb_redo_log_capacity and innodb_buffer_pool_size when innodb_dedicated_server=1 #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mershadi
Copy link

@mershadi mershadi commented Oct 7, 2024

Whenever innodb_dedicated_server is enabled, resetting innodb_buffer_pool_size to the 'default' value, resets it to the default of 128 MB instead of resetting it to the value calculated by innodb_dedicated_server.

We see a similar behavior with innodb_redo_log_capacity where it resets to the engine default of 100 MB when a custom value for innodb_redo_log_capacity was set in the my.cnf file at engine startup. However, if the value for innodb_redo_log_capacity was not set in the my.cnf file at engine startup, resetting the parameter sets it to the value calculated by innodb_dedicated_server i.e. nVCPU/2 GB.

The expected behavior is that the parameter value for innodb_buffer_pool_size and innodb_redo_log_capacity should reset to the value calculated by innodb_dedicated_server irrespective of weather of not it has been set in the my.cnf file.

This commit fixes bugs https://bugs.mysql.com/bug.php?id=115757 and https://bugs.mysql.com/bug.php?id=115759 .

This contribution is under the OCA signed by Amazon and covering submissions to the MySQL project.

…e when innodb_dedicated_server=1

Whenever innodb_dedicated_server is enabled, resetting innodb_buffer_pool_size
to the 'default' value, resets it to the default of 128 MB instead of resetting
it to the value calculated by innodb_dedicated_server.

We see a similar behavior with innodb_redo_log_capacity where it resets to the
engine default of 100 MB when a custom value for innodb_redo_log_capacity was
set in the my.cnf file at engine startup. However, if the value for
innodb_redo_log_capacity was not set in the my.cnf file at engine startup,
resetting the parameter sets it to the value calculated by
innodb_dedicated_server i.e. nVCPU/2 GB.

The expected behavior is that the parameter value for innodb_buffer_pool_size
and innodb_redo_log_capacity should reset to the value calculated by
innodb_dedicated_server irrespective of weather of not it has been set in the
my.cnf file.

This commit fixes bugs https://bugs.mysql.com/bug.php?id=115757 and
https://bugs.mysql.com/bug.php?id=115759 .

This contribution is under the OCA signed by Amazon and covering submissions to
the MySQL project.
@mysql-oca-bot
Copy link

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/
Please make sure to include your MySQL bug system user (email) in the returned form.
Thanks

@mershadi
Copy link
Author

mershadi commented Oct 10, 2024

This contribution is under the OCA signed by Amazon and covering submissions to the MySQL project.

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment:
"I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it."
Thanks

@mershadi
Copy link
Author

I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow
bug http://bugs.mysql.com/bug.php?id=116383 for updates.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants