Fix for resetting innodb_redo_log_capacity and innodb_buffer_pool_size when innodb_dedicated_server=1 #566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever innodb_dedicated_server is enabled, resetting innodb_buffer_pool_size to the 'default' value, resets it to the default of 128 MB instead of resetting it to the value calculated by innodb_dedicated_server.
We see a similar behavior with innodb_redo_log_capacity where it resets to the engine default of 100 MB when a custom value for innodb_redo_log_capacity was set in the my.cnf file at engine startup. However, if the value for innodb_redo_log_capacity was not set in the my.cnf file at engine startup, resetting the parameter sets it to the value calculated by innodb_dedicated_server i.e. nVCPU/2 GB.
The expected behavior is that the parameter value for innodb_buffer_pool_size and innodb_redo_log_capacity should reset to the value calculated by innodb_dedicated_server irrespective of weather of not it has been set in the my.cnf file.
This commit fixes bugs https://bugs.mysql.com/bug.php?id=115757 and https://bugs.mysql.com/bug.php?id=115759 .
This contribution is under the OCA signed by Amazon and covering submissions to the MySQL project.