bug #82039: Add valgrind tool to MTR #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
grooverdan
changed the title
dbussink
added a commit
to planetscale/mysql-server
that referenced
this pull request
Dec 6, 2023
* Only report unstable tests and don't fail the build * Show contents of log files after test failures * Add a --flakes option * Start a list of known flaky tests: flaky-tests.txt * Add more flaky tests from mysql#82 * One more flaky test * Fix and check the path to flaky-tests.txt * Ensure --flakes gets a non-empty arg Oddly, `--flakes` is ignored, as is `--flakes=""`, because getopt doesn't call the handler in either of those cases. However: `--flakes ""` will now trigger the `die` added here. The idea here is to catch the error corrected in fe801e631d5a. * Fix path for flaky tests file This fixes the path for the flaky tests, fixes the logic for reading the hash, decreases parallelism further and adds a bunch of tests to the flakes set. * Add flaky tests seen in mysql#80 --------- Co-authored-by: Patrick Reynolds <patrick@piki.org> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
dbussink
added a commit
to planetscale/mysql-server
that referenced
this pull request
Dec 7, 2023
* Only report unstable tests and don't fail the build * Show contents of log files after test failures * Add a --flakes option * Start a list of known flaky tests: flaky-tests.txt * Add more flaky tests from mysql#82 * One more flaky test * Fix and check the path to flaky-tests.txt * Ensure --flakes gets a non-empty arg Oddly, `--flakes` is ignored, as is `--flakes=""`, because getopt doesn't call the handler in either of those cases. However: `--flakes ""` will now trigger the `die` added here. The idea here is to catch the error corrected in fe801e631d5a. * Fix path for flaky tests file This fixes the path for the flaky tests, fixes the logic for reading the hash, decreases parallelism further and adds a bunch of tests to the flakes set. * Add flaky tests seen in mysql#80 --------- Co-authored-by: Patrick Reynolds <patrick@piki.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using other valgrind tools in MTR is a little difficult as the MTR ties the tool to memcheck or calllgrind.
This provides a valgrind-tool option for easy selection.
MTR_TEST_NAME is also exported for recording results per test run (using a custom --valgrind-path= wrapper script).