bug 82427: Check filesize read in sql authentication plugin (5.7) #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids compile error: sql/auth/sql_authentication.cc: In member function 'bool Rsa_authentication_keys::read_key_file(RSA**, bool, char**)': sql/auth/sql_authentication.cc:220:60: error: ignoring return value of 'size_t fread(void*, size_t, size_t, FILE*)', declared with attribute warn_unused_result [-Werror=unused-result] (void) fread(*key_text_buffer, filesize, 1, key_file);
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
grooverdan
changed the title
gunnarku
pushed a commit
to facebook/mysql-8.0
that referenced
this pull request
Jul 21, 2017
…h Trx API Summary: - Make DDL commands write into non-indexed WriteBatch when this is safe (i.e. when not constructing a unique index) - Make DML commands not to acquire transaction locks when modifying secondary indexes (this is not necessary). The patch also fixess Issue mysql#88. Test Plan: Run MTR Reviewers: jtolmer, jkedgar, yoshinorim, anthony, hermanlee4 Reviewed By: hermanlee4 Subscribers: webscalesql-eng Differential Revision: https://reviews.facebook.net/D49659 Differential Revision: https://reviews.facebook.net/D51675
gunnarku
pushed a commit
to facebook/mysql-8.0
that referenced
this pull request
Jul 25, 2017
…h Trx API Summary: - Make DDL commands write into non-indexed WriteBatch when this is safe (i.e. when not constructing a unique index) - Make DML commands not to acquire transaction locks when modifying secondary indexes (this is not necessary). The patch also fixess Issue mysql#88. Test Plan: Run MTR Reviewers: jtolmer, jkedgar, yoshinorim, anthony, hermanlee4 Reviewed By: hermanlee4 Subscribers: webscalesql-eng Differential Revision: https://reviews.facebook.net/D49659 Differential Revision: https://reviews.facebook.net/D51675
dbussink
added a commit
to planetscale/mysql-server
that referenced
this pull request
Dec 7, 2023
We want to force a new version here, so let's make sure we have new epoch here as well. This is something we really need to automate / inject somehow so that we can force a fresh one automatically for each different sha. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids compile error in gcc-5.4.0 (the default in Ubuntu-16.04)
sql/auth/sql_authentication.cc: In member function 'bool Rsa_authentication_keys::read_key_file(RSA**, bool, char**)':
sql/auth/sql_authentication.cc:220:60: error: ignoring return value of 'size_t fread(void_, size_t, size_t, FILE_)', declared with attribute warn_unused_result -Werror=unused-result fread(*key_text_buffer, filesize, 1, key_file);