Encapsulate table names in mysqlimport #90
Conversation
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html |
|
@mysql-oca-bot thanks, done. |
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
|
|
||
| if (verbose) | ||
| fprintf(stdout, "Locking tables for write\n"); | ||
| init_dynamic_string(&query, "LOCK TABLES ", 256, 1024); | ||
| for (i=0 ; i < tablecount ; i++) | ||
| { | ||
| fn_format(tablename, raw_tablename[i], "", "", 1 | 2); | ||
| dynstr_append(&query, tablename); | ||
| dynstr_append(&query, " WRITE,"); | ||
| dynstr_append(&query, "`"); |
There was a problem hiding this comment.
I suggest you use the new mysql_real_escape_string_quote() API here instead of trying to do the escaping yourself.
There was a problem hiding this comment.
@gkodinov thanks. In that case https://github.com/mysql/mysql-server/blob/5.7/client/mysqlimport.c#L387 should be adapted as well.
Signed-off-by: Matt Layher <mdlayher@planetscale.com>
Locking tables in mysqlimport fails if
This PR encapsulates table names in backticks and replaces backticks by double backticks, to solve both issues.