Fix handling of table/schema names containing non-ASCII characters in get_schema_inconsistency_check() for MySQL 5.7 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… get_schema_inconsistency_check() for MySQL 5.7 In mysql@db79350, Konrad Olesinski <konrad.olesinski@oracle.com> modified `get_schema_inconsistency_check` to "remove[d] false positives related to full Unicode range." It appears that the intention of this change was to ignore table names containing non-ASCII characters, since their names are represented differently in `information_schema.tables` and in `information_schema.innodb_sys_tables`. In the latter, disallowed characters are replaced with '@' plus 4 hexadecimal digits representing the character's Unicode codepoint. However, the regular expression used for this (`@[0-9]`) was incorrect and incomplete: it will *only* exclude Unicode codepoints 0x0000-0x9ffff, and *won't* exclude Unicode codepoints 0xa000-0xffff. This commit fixes the mistake in the regular expression. In the longer term, tables whose names contain non-ASCII characters should *not* be excluded from schema inconsistency checks. This contribution is under the OCA signed by Amazon and covering submissions to the MySQL project.
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA signed by Amazon and covering submissions to the MySQL project, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In db79350, @konrado0 modified
get_schema_inconsistency_checkto "remove[d] false positives related to full Unicode range."It appears that the intention of this change was to ignore table names containing non-ASCII characters, since their names are represented differently in
information_schema.tablesand ininformation_schema.innodb_sys_tables. In the latter, disallowed characters are replaced with '@' plus 4 hexadecimal digits representing the character's Unicode codepoint.However, the regular expression used for this (
@[0-9]) was incorrect and incomplete: it will only exclude Unicode codepoints 0x0000-0x9ffff, and won't exclude Unicode codepoints 0xa000-0xffff. This commit fixes the mistake in the regular expression.In the longer term, tables whose names contain non-ASCII characters should not be excluded from schema inconsistency checks.
This contribution is under the OCA signed by Amazon and covering submissions to the MySQL project.