v8 should be 6.7.288.46 according to 7185c30c808e729f4da7f74425a782cc… #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
nawazn
pushed a commit
that referenced
this pull request
Jul 22, 2019
…on To Enter Password
The problem was caused because the password was being incorrectly initialized to
"", having a specific value caused the prompt to get the password to not be shown.
Additional changes:
- Added validations on Configure_instance:
- clusterAdminPassword with no clusterAdmin results in an error.
- clusterAdminPassword for existing clusterAdmin results in an error.
- Updated documentation:
- Removed duplicated definition of documentation for common bits in configureInstance
and configureLocalInstance.
- Updated the documentation for the new validations.
- Fixed issue in API Docs CMakeLists.txt that caused documentation to be messed up.
- Added testutil.assertNoPrompts to be able to verify no prompts are left at the end
of the execution of a chunk
Change-Id: I5a492fb62b203e84aff2e07186ce8130fb7b513e
bkandasa
pushed a commit
that referenced
this pull request
Apr 27, 2020
In Cluster.setInstanceOption(), if third argument is of wrong type, the error message mistakenly refers to it as a second argument. This bug is now fixed, error message correctly points out to the wrong argument. Change-Id: Id7afc9f6352a891650ade340eff8662d71ce842b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…3c56cc87 commit