extracted 'expose_as' controller helper into SingleControllerInherita…

…nce module

app/controllers/admin/posts_controller.rb

@@ -1,19 +1,4 @@
 class Admin::PostsController < Application
-  def self.expose_as(*types)
-    types.each do |name|
-      controller_title = name.to_s.tableize.titleize + 'Controller'
-      controller_class = Class.new(PostsController) do
-        define_method(:post_type) { name }
-      end
-
-      logger.info "=> Generating new PostsController subclass"
-      logger.info "   Class name: #{controller_title}"
-      logger.info "   Class: #{controller_class.inspect}"
-
-      Admin.const_set(controller_title, controller_class)
-    end
-  end
-
   rescue_from ActiveRecord::RecordNotFound, :with => :not_found
 
   before_filter :login_required

app/controllers/posts_controller.rb

@@ -2,23 +2,7 @@ class PostsController < Application
   @@subtypes = []
   cattr_reader :subtypes
 
-  def self.expose_as(*types)
-    options = types.extract_options!
-    types.each do |name|
-      PostsController.subtypes << name.to_s
-      controller_title = options[:namespace].to_s + name.to_s.tableize.titleize + 'Controller'
-      controller_class = Class.new(PostsController) do
-        prepend_view_path File.join(Rails.root, *%w[app views posts])
-        prepend_view_path File.join(Rails.root, *%w[app views posts types])
-        prepend_view_path File.join(Rails.root, *%w[app views posts forms])
-        define_method(:post_type) { name }
-      end
-
-      logger.info "=> Generating new #{options[:namespace]}PostsController subclass: #{controller_title}"
-
-      Object.const_set(controller_title, controller_class)
-    end
-  end
+  include SingleControllerInheritance
 
   rescue_from ActiveRecord::RecordNotFound, :with => :not_found
 
@@ -27,7 +11,10 @@ def self.expose_as(*types)
   caches_page :index
   caches_page :show
 
-  expose_as :articles, :links, :pictures, :quotes, :snippets, :tweets, :gists
+  expose_as :articles, :links, :pictures, :quotes, :snippets, :tweets, :gists do |name|
+    subtypes << name
+    define_method(:post_type) { name }
+  end
 
   # GET /posts
   # GET /posts.xml

config/environment.rb

@@ -11,6 +11,7 @@
 require File.join(File.dirname(__FILE__), 'boot')
 
 require 'authenticated_model'
+require 'single_controller_inheritance'
 
 Rails::Initializer.run do |config|
   config.load_paths += %W[

lib/single_controller_inheritance.rb

@@ -0,0 +1,24 @@
+module SingleControllerInheritance
+  def self.included(base)
+    base.extend ClassMethods
+  end
+
+  module ClassMethods
+    def expose_as(*types, &block)
+      options = types.extract_options!
+      namespace = options[:namespace]
+
+      types.each do |child|
+        class_name = namespace.to_s + child.to_s.titleize + 'Controller'
+        controller = Class.new(self) do
+          block[child] if block_given?
+        end
+
+        logger.info "=> Generating new %s subclass: %s" % [child, class_name]
+
+        scope = namespace ? namespace.constantize : Object
+        scope.const_set(class_name, controller)
+      end
+    end
+  end
+end

test/functional/admin_posts_controller_test.rb

@@ -39,7 +39,9 @@ def test_should_get_index
   end
 
   # Post types
-
+  # NOTE Since these are all now handled by dynamically created controllers,
+  #      we'll need a different way of testing them.
+  #
   # def test_should_retrieve_links_only
   #   @request.stubs(:path).returns('/links')
   #   Link.expects(:paginate_index).returns(posts_stub)

test/functional/posts_controller_test.rb

@@ -44,6 +44,9 @@ def test_should_redirect_to_admin_show_if_logged_in_even_for_relative_urls
   end
 
   # # Post types
+  #
+  # NOTE Since these are all now handled by dynamically created controllers,
+  #      we'll need a different way of testing them.
   # 
   # def test_should_retrieve_links_only
   #   @request.stubs(:path).returns('/links')