Merge pull request #1122 from nanoc/no-avg

Show percentiles rather than average
nanoc · Mar 17, 2017 · 24b8378 · 24b8378
2 parents 11127d7 + e2f6940
commit 24b8378
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/lib/nanoc/cli/commands/compile_listeners/timing_recorder.rb b/lib/nanoc/cli/commands/compile_listeners/timing_recorder.rb
@@ -107,16 +107,18 @@ def stop
     protected
 
     def table_for_summary(name)
-      headers = [name.to_s, 'count', 'min', 'avg', 'max', 'tot']
+      headers = [name.to_s, 'count', 'min', '.50', '.90', '.95', 'max', 'tot']
 
       rows = @telemetry.summary(name).map do |filter_name, summary|
         count = summary.count
         min   = summary.min
-        avg   = summary.avg
+        p50   = summary.quantile(0.50)
+        p90   = summary.quantile(0.90)
+        p95   = summary.quantile(0.95)
         tot   = summary.sum
         max   = summary.max
 
-        [filter_name, count.to_s] + [min, avg, max, tot].map { |r| "#{format('%4.2f', r)}s" }
+        [filter_name, count.to_s] + [min, p50, p90, p95, max, tot].map { |r| "#{format('%4.2f', r)}s" }
       end
 
       [headers] + rows

diff --git a/spec/nanoc/cli/commands/compile/timing_recorder_spec.rb b/spec/nanoc/cli/commands/compile/timing_recorder_spec.rb
@@ -40,7 +40,7 @@
     Nanoc::Int::NotificationCenter.post(:filtering_ended, rep, :erb)
 
     expect { listener.stop }
-      .to output(/^\s*erb │     2   1\.00s   1\.50s   2\.00s   3\.00s$/).to_stdout
+      .to output(/^\s*erb │     2   1\.00s   1\.50s   1\.90s   1\.95s   2\.00s   3\.00s$/).to_stdout
   end
 
   it 'records single from filtering_started to filtering_ended' do
@@ -228,7 +228,7 @@
     Nanoc::Int::NotificationCenter.post(:outdatedness_rule_ended, Nanoc::Int::OutdatednessRules::CodeSnippetsModified, rep)
 
     expect { listener.stop }
-      .to output(/^\s*CodeSnippetsModified │     1   1\.00s   1\.00s   1\.00s   1\.00s$/).to_stdout
+      .to output(/^\s*CodeSnippetsModified │     1   1\.00s   1\.00s   1\.00s   1\.00s   1\.00s   1\.00s$/).to_stdout
   end
 
   it 'records single outdatedness rule duration' do