Remove compiler stack #1000
Merged
Remove compiler stack #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
force-pushed
the
wrap-item-rep-in-error
branch
5 times, most recently
from
84e2cdb
to
460500a
Compare
denisdefreyne
force-pushed
the
wrap-item-rep-in-error
branch
from
12fe074
to
3036e92
Compare
denisdefreyne
force-pushed
the
wrap-item-rep-in-error
branch
from
bbd485c
to
ffce22c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the compiler stack and print the details of the current in-compilation item rep.
Detailed description
This is done in two steps:
Wrap every error raised during compilation in an error decorator that will contain the current item rep that is being compiled, and ensure that item rep is printed in the error handler.
Remove the now unused compiler stack.
Before:
After:
To do
WithItemRepErrortoCompilerErrorrespond_to?