Only treat :last snapshot as movable #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
force-pushed
the
fix-moving-pre-snapshots
branch
from
4c615e5
to
ef5cfd0
Compare
denisdefreyne
force-pushed
the
fix-moving-pre-snapshots
branch
from
95971f7
to
55b8f52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
:pre,:postand:lastsnapshots have typically been marked as “movable”, which means that in order to access content at those snapshots, certain requirements have to be met. The logic around this is confusing, and so this PR simplifies this.The only snapshot that is “movable” is the
:lastsnapshot.To access compiled content of a snapshot, the snapshot content needs to exist, or, for
:last, the item rep needs to have been fully compiled.The executor no longer creates snapshots in
#filterand#layout. The recording executor (or generally speaking, the rule DSL) takes care of generating the appropriate snapshots.Snapshot defs and snapshot actions cannot be non-final.
Fixes #1040.