Make item/layout collection dependencies finer-grained #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
force-pushed
the
finer-doc-collection-dependencies
branch
2 times, most recently
from
eecdebc
to
1a12a41
Compare
denisdefreyne
force-pushed
the
finer-doc-collection-dependencies
branch
from
1a12a41
to
69f9585
Compare
denisdefreyne
force-pushed
the
finer-doc-collection-dependencies
branch
3 times, most recently
from
781b853
to
57619db
Compare
denisdefreyne
force-pushed
the
finer-doc-collection-dependencies
branch
from
c375313
to
218259e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies on the item/layout collection are currently all-or-nothing. Any item that directly or indirectly accesses
@itemsor@layoutswill have a a dependency on the entire collection of items/layouts. This means that adding a new item or a new layout will cause these items to be marked as outdated, even if they won’t depend on that specific new layout.This PR makes
@items[]and@items.find_all(same for@layout) generate finer-grained dependencies, which only depend on a subset of the collection of items (or layouts). This way, adding a new item or layout is less likely to cause other items to be recompiled.