Let #load_site not set site ivar #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
force-pushed
the
immutable-load-site
branch
from
4ed6dfb
to
d59e26e
Compare
denisdefreyne
force-pushed
the
immutable-load-site
branch
from
d59e26e
to
1ac16ba
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mutable state introduced by letting
#load_siteset the@siteivar is troubling (see #1211 for a case where I was bitten by this).This PR lets
#load_sitereturn the new site, rather than set@site. I’ve opted to let the command runners assign the return value of#load_siteto@site, which, even though not perfect, is more reasonable.